"vllm/vscode:/vscode.git/clone" did not exist on "92da847cf5f4eedf0bc9fed45d7c076be78b8c1f"
Unverified Commit 3057af00 authored by Thomas Montfort's avatar Thomas Montfort Committed by GitHub
Browse files

feat(dep-715): refactor helm directory and remove reference to cloud (#5042)

parent b5922693
......@@ -21,7 +21,7 @@ import (
"strings"
"testing"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
......
......@@ -21,7 +21,7 @@ import (
"fmt"
"strings"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
)
......
......@@ -21,8 +21,8 @@ import (
"context"
"fmt"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
internalwebhook "github.com/ai-dynamo/dynamo/deploy/cloud/operator/internal/webhook"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
internalwebhook "github.com/ai-dynamo/dynamo/deploy/operator/internal/webhook"
"k8s.io/apimachinery/pkg/runtime"
"sigs.k8s.io/controller-runtime/pkg/log"
"sigs.k8s.io/controller-runtime/pkg/manager"
......
......@@ -20,7 +20,7 @@ package validation
import (
"testing"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
......
......@@ -20,7 +20,7 @@ package validation
import (
"fmt"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
)
......
......@@ -20,7 +20,7 @@ package validation
import (
"testing"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/cloud/operator/api/v1alpha1"
nvidiacomv1alpha1 "github.com/ai-dynamo/dynamo/deploy/operator/api/v1alpha1"
"k8s.io/apimachinery/pkg/api/resource"
)
......
......@@ -25,7 +25,7 @@ import (
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
"github.com/ai-dynamo/dynamo/deploy/cloud/operator/test/utils"
"github.com/ai-dynamo/dynamo/deploy/operator/test/utils"
)
const namespace = "dynamo-kubernetes-operator-system"
......
......@@ -21,7 +21,7 @@ This directory contains a pre-deployment check script that verifies your Kuberne
- For NCCL tests, please refer to the [NCCL tests](https://docs.nebius.com/kubernetes/gpu/nccl-test#run-tests) for more details.
For the latest pre-deployment check instructions, see the [main branch version of this README](https://github.com/ai-dynamo/dynamo/blob/main/deploy/cloud/pre-deployment/README.md).
For the latest pre-deployment check instructions, see the [main branch version of this README](https://github.com/ai-dynamo/dynamo/blob/main/deploy/pre-deployment/README.md).
## Usage
......
......@@ -4,9 +4,9 @@ This directory contains utilities and manifests for Dynamo benchmarking and prof
## Prerequisites
**Before using these utilities, you must first set up Dynamo Cloud following the main installation guide:**
**Before using these utilities, you must first set up Dynamo Kubernetes Platform following the main installation guide:**
👉 **[Follow the Dynamo Cloud installation guide](/docs/kubernetes/installation_guide.md) to install the Dynamo Kubernetes Platform first.**
👉 **[Follow the Dynamo Kubernetes Platform installation guide](/docs/kubernetes/installation_guide.md) to install the Dynamo Kubernetes Platform first.**
This includes:
1. Installing the Dynamo CRDs
......@@ -27,7 +27,7 @@ This includes:
### Benchmarking Resource Setup
After setting up Dynamo Cloud, use this script to prepare your namespace with the additional resources needed for benchmarking and profiling workflows:
After setting up Dynamo Kubernetes Platform, use this script to prepare your namespace with the additional resources needed for benchmarking and profiling workflows:
The setup script creates a `dynamo-pvc` with `ReadWriteOnce` (RWO) access mode using your cluster's default storage class. This is sufficient for profiling workflows where only one job writes at a time.
......
......@@ -593,6 +593,6 @@ async def main():
# run with:
# uv run benchmarks/profiler/utils/dynamo_deployment.py -n mo-dyn-cloud -f ./examples/vllm/deploy/agg.yaml -l ./client_logs
# uv run benchmarks/profiler/utils/dynamo_deployment.py -n mo-dyn -f ./examples/vllm/deploy/agg.yaml -l ./client_logs
if __name__ == "__main__":
asyncio.run(main())
......@@ -35,7 +35,7 @@ Sets up benchmarking and profiling resources in an existing Dynamo namespace:
- Installs benchmark dependencies if requirements.txt exists
Prerequisites:
- Dynamo Cloud platform must already be installed in the namespace
- Dynamo Kubernetes Platform must already be installed in the namespace
- kubectl must be configured and pointing to the target cluster
Environment variables:
......@@ -48,14 +48,14 @@ if ! command -v kubectl &>/dev/null; then err "kubectl not found"; exit 1; fi
# Check if namespace exists
if ! kubectl get namespace "$NAMESPACE" &>/dev/null; then
err "Namespace $NAMESPACE does not exist. Please create it first or install Dynamo Cloud platform."
err "Namespace $NAMESPACE does not exist. Please create it first or install Dynamo Kubernetes Platform."
exit 1
fi
# Check if Dynamo platform is installed
if ! kubectl get pods -n "$NAMESPACE" | grep -q "dynamo-platform"; then
warn "Dynamo platform pods not found in namespace $NAMESPACE"
warn "Please ensure Dynamo Cloud platform is installed first:"
warn "Please ensure Dynamo Kubernetes Platform is installed first:"
warn " See: docs/kubernetes/installation_guide.md"
if [[ -z "${FORCE:-}" && -z "${YES:-}" ]]; then
read -p "Continue anyway? [y/N]: " -r ans
......
......@@ -62,24 +62,24 @@ $(HELM_DOCS): $(LOCALBIN)
.PHONY: generate-helm-docs
generate-helm-docs: helm-docs-install ## Generate README.md for Helm charts from values.yaml
@echo "📚 Generating Helm chart documentation..."
@cd ../deploy/cloud/helm/platform && $(realpath $(HELM_DOCS)) \
@cd ../deploy/helm/charts/platform && $(realpath $(HELM_DOCS)) \
--template-files=README.md.gotmpl \
--output-file=README.md \
--sort-values-order=file \
--chart-to-generate=. \
--ignore-non-descriptions
@echo "✅ Generated documentation at ../deploy/cloud/helm/platform/README.md"
@echo "✅ Generated documentation at ../deploy/helm/charts/platform/README.md"
.PHONY: helm-docs-clean
helm-docs-clean: ## Remove generated helm documentation
@echo "🧹 Cleaning generated helm documentation..."
@rm -f ../deploy/cloud/helm/platform/README.md
@rm -f ../deploy/helm/charts/platform/README.md
@echo "✅ Cleaned helm documentation"
.PHONY: generate-crd-docs
generate-crd-docs: ## Generate CRD API reference documentation
@echo "📚 Generating CRD API reference documentation..."
@cd ../deploy/cloud/operator && make generate-api-docs
@cd ../deploy/operator && make generate-api-docs
@echo "✅ CRD API reference generated"
.PHONY: docs-all
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment