Unverified Commit 14d92993 authored by Frank Lee's avatar Frank Lee Committed by GitHub
Browse files

[cli] fixed hostname mismatch error (#2465)

parent c20529fe
from typing import List
import socket import socket
from typing import List
class HostInfo: class HostInfo:
...@@ -35,9 +35,14 @@ class HostInfo: ...@@ -35,9 +35,14 @@ class HostInfo:
if port is None: if port is None:
port = 22 # no port specified, lets just use the ssh port port = 22 # no port specified, lets just use the ssh port
hostname = socket.getfqdn(hostname)
# socket.getfqdn("127.0.0.1") does not return localhost
# on some users' machines
# thus, we directly return True if hostname is locahost, 127.0.0.1 or 0.0.0.0
if hostname in ("localhost", "127.0.0.1", "0.0.0.0"): if hostname in ("localhost", "127.0.0.1", "0.0.0.0"):
return True return True
hostname = socket.getfqdn(hostname)
localhost = socket.gethostname() localhost = socket.gethostname()
localaddrs = socket.getaddrinfo(localhost, port) localaddrs = socket.getaddrinfo(localhost, port)
targetaddrs = socket.getaddrinfo(hostname, port) targetaddrs = socket.getaddrinfo(hostname, port)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment