Unverified Commit 945a559b authored by Kirthi Shankar Sivamani's avatar Kirthi Shankar Sivamani Committed by GitHub
Browse files

Remove deprecated interval arg to delayed scaling recipe (#1607)


Signed-off-by: default avatarKirthi Shankar Sivamani <ksivamani@nvidia.com>
parent 3dc8c6bc
......@@ -741,7 +741,6 @@ def _test_fp8_scale_update(
fp8_format = transformer_engine.common.recipe.Format.HYBRID
recipe = transformer_engine.common.recipe.DelayedScaling(
margin=margin,
interval=1,
fp8_format=fp8_format,
amax_history_len=amax_history_len,
amax_compute_algo=amax_compute_algo,
......
......@@ -288,7 +288,6 @@ class TestFuser:
fp8_format = transformer_engine.common.recipe.Format.HYBRID
recipe = transformer_engine.common.recipe.DelayedScaling(
margin=margin,
interval=1,
fp8_format=fp8_format,
amax_history_len=8,
amax_compute_algo="max",
......
......@@ -176,7 +176,6 @@ class TestFP8Recipe:
fp8_format = transformer_engine.common.recipe.Format.HYBRID
recipe = transformer_engine.common.recipe.DelayedScaling(
margin=margin,
interval=1,
fp8_format=fp8_format,
amax_history_len=amax_history_len,
amax_compute_algo=amax_compute_algo,
......
......@@ -162,7 +162,6 @@ class DelayedScaling(Recipe):
"""
margin: int = 0
interval: int = -1
fp8_format: Format = Format.HYBRID
amax_history_len: int = 1024
amax_compute_algo: Union[Literal["max", "most_recent"], Callable] = "max"
......@@ -173,12 +172,6 @@ class DelayedScaling(Recipe):
def __post_init__(self) -> None:
assert self.fp8_format != Format.E5M2, "Pure E5M2 training is not supported."
if self.interval >= 0:
warnings.warn(
"`interval` argument is deprecated and unused. "
"It will be removed in an upcoming release.",
DeprecationWarning,
)
def __repr__(self) -> str:
return (
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment