Unverified Commit 509ab0b0 authored by Jinze Xue's avatar Jinze Xue Committed by GitHub
Browse files

Enable incremental CMake build (#684)



* Enable incremental CMake build
Signed-off-by: default avatarJinze Xue <jinzex@nvidia.com>

* Update setup.py
Co-authored-by: default avatarTim Moon <4406448+timmoon10@users.noreply.github.com>
Signed-off-by: default avatarJinze Xue <155670984+jinzex@users.noreply.github.com>

* Update setup.py
Co-authored-by: default avatarTim Moon <4406448+timmoon10@users.noreply.github.com>
Signed-off-by: default avatarJinze Xue <155670984+jinzex@users.noreply.github.com>

* remove tempfile import
Signed-off-by: default avatarJinze Xue <jinzex@nvidia.com>

---------
Signed-off-by: default avatarJinze Xue <jinzex@nvidia.com>
Signed-off-by: default avatarJinze Xue <155670984+jinzex@users.noreply.github.com>
Co-authored-by: default avatarJinze Xue <jinzex@nvidia.com>
Co-authored-by: default avatarTim Moon <4406448+timmoon10@users.noreply.github.com>
Co-authored-by: default avatarKirthi Shankar Sivamani <ksivamani@nvidia.com>
parent 4e2ce516
...@@ -14,7 +14,6 @@ import subprocess ...@@ -14,7 +14,6 @@ import subprocess
from subprocess import CalledProcessError from subprocess import CalledProcessError
import sys import sys
import sysconfig import sysconfig
import tempfile
from typing import List, Optional, Tuple, Union from typing import List, Optional, Tuple, Union
import setuptools import setuptools
...@@ -360,8 +359,10 @@ class CMakeBuildExtension(BuildExtension): ...@@ -360,8 +359,10 @@ class CMakeBuildExtension(BuildExtension):
for ext in self.extensions: for ext in self.extensions:
if isinstance(ext, CMakeExtension): if isinstance(ext, CMakeExtension):
print(f"Building CMake extension {ext.name}") print(f"Building CMake extension {ext.name}")
with tempfile.TemporaryDirectory() as build_dir: # Set up incremental builds for CMake extensions
build_dir = Path(build_dir) setup_dir = Path(__file__).resolve().parent
build_dir = setup_dir / "build" / "cmake"
build_dir.mkdir(parents=True, exist_ok=True) # Ensure the directory exists
package_path = Path(self.get_ext_fullpath(ext.name)) package_path = Path(self.get_ext_fullpath(ext.name))
install_dir = package_path.resolve().parent install_dir = package_path.resolve().parent
ext._build_cmake( ext._build_cmake(
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment