Skip to content
GitLab
Menu
Projects
Groups
Snippets
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
OpenDAS
TransformerEngine
Commits
2c410836
Unverified
Commit
2c410836
authored
Oct 13, 2023
by
Tim Moon
Committed by
GitHub
Oct 13, 2023
Browse files
Explicitly specify that PyTorch QA tests use PyTorch (#476)
Signed-off-by:
Tim Moon
<
tmoon@nvidia.com
>
parent
35e687d0
Changes
7
Show whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
6 additions
and
6 deletions
+6
-6
.github/workflows/lint.yml
.github/workflows/lint.yml
+2
-2
CONTRIBUTING.rst
CONTRIBUTING.rst
+2
-2
qa/L0_pytorch_lint/CPPLINT.cfg
qa/L0_pytorch_lint/CPPLINT.cfg
+0
-0
qa/L0_pytorch_lint/format_py_files.sh
qa/L0_pytorch_lint/format_py_files.sh
+0
-0
qa/L0_pytorch_lint/pylintrc
qa/L0_pytorch_lint/pylintrc
+0
-0
qa/L0_pytorch_lint/test.sh
qa/L0_pytorch_lint/test.sh
+2
-2
qa/L0_pytorch_unittest/test.sh
qa/L0_pytorch_unittest/test.sh
+0
-0
No files found.
.github/workflows/lint.yml
View file @
2c410836
...
...
@@ -18,7 +18,7 @@ jobs:
run
:
|
export CPP_ONLY=1
export TE_PATH=.
bash ./qa/L0_lint/test.sh
bash ./qa/L0_
pytorch_
lint/test.sh
pytorch_pylint
:
name
:
'
PyTorch
Python'
runs-on
:
ubuntu-latest
...
...
@@ -34,7 +34,7 @@ jobs:
pip install flash-attn==1.0.2
export PYTHON_ONLY=1
export TE_PATH=.
bash ./qa/L0_lint/test.sh
bash ./qa/L0_
pytorch_
lint/test.sh
jax_cpplint
:
name
:
'
JAX
C++'
runs-on
:
ubuntu-latest
...
...
CONTRIBUTING.rst
View file @
2c410836
...
...
@@ -20,7 +20,7 @@ Coding Guidelines
.. code-block:: bash
TE_PATH=<path to TE source> bash qa/L0_lint/test.sh
TE_PATH=<path to TE source> bash qa/L0_
<framework>_
lint/test.sh
* Avoid introducing unnecessary complexity into existing code so that maintainability and
readability are preserved.
...
...
@@ -41,7 +41,7 @@ Coding Guidelines
- In the :bash:`qa/` directory, there are basic sanity tests scripted in directories named
`L0_...`. A given test can be executed by running the :bash:`./test.sh` command in each test
directory. The :bash:`test.sh` script assume that the TE source can be found under
directory. The :bash:`test.sh` script assume
s
that the TE source can be found under
:bash:`/opt/transformerengine`. This assumption can be changed by setting :bash:`TE_PATH`
environment variable to the directory containing TE source.
- One of the tests, `L0_license` tests for valid NVIDIA copyright and license text. If you create
...
...
qa/L0_lint/CPPLINT.cfg
→
qa/L0_
pytorch_
lint/CPPLINT.cfg
View file @
2c410836
File moved
qa/L0_lint/format_py_files.sh
→
qa/L0_
pytorch_
lint/format_py_files.sh
View file @
2c410836
File moved
qa/L0_lint/pylintrc
→
qa/L0_
pytorch_
lint/pylintrc
View file @
2c410836
File moved
qa/L0_lint/test.sh
→
qa/L0_
pytorch_
lint/test.sh
View file @
2c410836
...
...
@@ -9,7 +9,7 @@ set -e
pip
install
cpplint
==
1.6.0
pylint
==
2.13.5
if
[
-z
"
${
PYTHON_ONLY
}
"
]
then
cp
$TE_PATH
/qa/L0_lint/CPPLINT.cfg
$TE_PATH
cp
$TE_PATH
/qa/L0_
pytorch_
lint/CPPLINT.cfg
$TE_PATH
cd
$TE_PATH
echo
"Checking common API headers"
cpplint
--root
transformer_engine/common/include
--recursive
transformer_engine/common/include
...
...
@@ -19,7 +19,7 @@ then
fi
if
[
-z
"
${
CPP_ONLY
}
"
]
then
cp
$TE_PATH
/qa/L0_lint/pylintrc
$TE_PATH
cp
$TE_PATH
/qa/L0_
pytorch_
lint/pylintrc
$TE_PATH
cd
$TE_PATH
echo
"Checking Python files"
pylint
--recursive
=
y transformer_engine/common transformer_engine/pytorch
...
...
qa/L0_unittest/test.sh
→
qa/L0_
pytorch_
unittest/test.sh
View file @
2c410836
File moved
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment