Unverified Commit 2c410836 authored by Tim Moon's avatar Tim Moon Committed by GitHub
Browse files

Explicitly specify that PyTorch QA tests use PyTorch (#476)


Signed-off-by: default avatarTim Moon <tmoon@nvidia.com>
parent 35e687d0
...@@ -18,7 +18,7 @@ jobs: ...@@ -18,7 +18,7 @@ jobs:
run: | run: |
export CPP_ONLY=1 export CPP_ONLY=1
export TE_PATH=. export TE_PATH=.
bash ./qa/L0_lint/test.sh bash ./qa/L0_pytorch_lint/test.sh
pytorch_pylint: pytorch_pylint:
name: 'PyTorch Python' name: 'PyTorch Python'
runs-on: ubuntu-latest runs-on: ubuntu-latest
...@@ -34,7 +34,7 @@ jobs: ...@@ -34,7 +34,7 @@ jobs:
pip install flash-attn==1.0.2 pip install flash-attn==1.0.2
export PYTHON_ONLY=1 export PYTHON_ONLY=1
export TE_PATH=. export TE_PATH=.
bash ./qa/L0_lint/test.sh bash ./qa/L0_pytorch_lint/test.sh
jax_cpplint: jax_cpplint:
name: 'JAX C++' name: 'JAX C++'
runs-on: ubuntu-latest runs-on: ubuntu-latest
......
...@@ -20,7 +20,7 @@ Coding Guidelines ...@@ -20,7 +20,7 @@ Coding Guidelines
.. code-block:: bash .. code-block:: bash
TE_PATH=<path to TE source> bash qa/L0_lint/test.sh TE_PATH=<path to TE source> bash qa/L0_<framework>_lint/test.sh
* Avoid introducing unnecessary complexity into existing code so that maintainability and * Avoid introducing unnecessary complexity into existing code so that maintainability and
readability are preserved. readability are preserved.
...@@ -41,7 +41,7 @@ Coding Guidelines ...@@ -41,7 +41,7 @@ Coding Guidelines
- In the :bash:`qa/` directory, there are basic sanity tests scripted in directories named - In the :bash:`qa/` directory, there are basic sanity tests scripted in directories named
`L0_...`. A given test can be executed by running the :bash:`./test.sh` command in each test `L0_...`. A given test can be executed by running the :bash:`./test.sh` command in each test
directory. The :bash:`test.sh` script assume that the TE source can be found under directory. The :bash:`test.sh` script assumes that the TE source can be found under
:bash:`/opt/transformerengine`. This assumption can be changed by setting :bash:`TE_PATH` :bash:`/opt/transformerengine`. This assumption can be changed by setting :bash:`TE_PATH`
environment variable to the directory containing TE source. environment variable to the directory containing TE source.
- One of the tests, `L0_license` tests for valid NVIDIA copyright and license text. If you create - One of the tests, `L0_license` tests for valid NVIDIA copyright and license text. If you create
......
...@@ -9,7 +9,7 @@ set -e ...@@ -9,7 +9,7 @@ set -e
pip install cpplint==1.6.0 pylint==2.13.5 pip install cpplint==1.6.0 pylint==2.13.5
if [ -z "${PYTHON_ONLY}" ] if [ -z "${PYTHON_ONLY}" ]
then then
cp $TE_PATH/qa/L0_lint/CPPLINT.cfg $TE_PATH cp $TE_PATH/qa/L0_pytorch_lint/CPPLINT.cfg $TE_PATH
cd $TE_PATH cd $TE_PATH
echo "Checking common API headers" echo "Checking common API headers"
cpplint --root transformer_engine/common/include --recursive transformer_engine/common/include cpplint --root transformer_engine/common/include --recursive transformer_engine/common/include
...@@ -19,7 +19,7 @@ then ...@@ -19,7 +19,7 @@ then
fi fi
if [ -z "${CPP_ONLY}" ] if [ -z "${CPP_ONLY}" ]
then then
cp $TE_PATH/qa/L0_lint/pylintrc $TE_PATH cp $TE_PATH/qa/L0_pytorch_lint/pylintrc $TE_PATH
cd $TE_PATH cd $TE_PATH
echo "Checking Python files" echo "Checking Python files"
pylint --recursive=y transformer_engine/common transformer_engine/pytorch pylint --recursive=y transformer_engine/common transformer_engine/pytorch
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment